Add PHPUnit workflow, fix path handling bug, REUSE/php-cs compliance#722
Open
Add PHPUnit workflow, fix path handling bug, REUSE/php-cs compliance#722
Conversation
… createBackup() Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com> Agent-Logs-Url: https://github.com/nextcloud/updater/sessions/5f2df1e7-e17a-4242-b4c3-91a831b9048d
…cloud/privacy pattern Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com> Agent-Logs-Url: https://github.com/nextcloud/updater/sessions/5f2df1e7-e17a-4242-b4c3-91a831b9048d
Copilot
AI
changed the title
[WIP] Add string concat method for nextcloudDir concatenations
feat: add Mar 25, 2026
buildPath() helper and fix double-slash bug in createBackup()
Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com> Agent-Logs-Url: https://github.com/nextcloud/updater/sessions/f6fad36e-0af0-4aee-b04b-3faae41f45f3
#711 regression tests Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com> Agent-Logs-Url: https://github.com/nextcloud/updater/sessions/f6fad36e-0af0-4aee-b04b-3faae41f45f3
Copilot
AI
changed the title
feat: add
fix: centralise path building, fix explode-based double-slash bug (issue #711), add PHPUnit
Mar 25, 2026
buildPath() helper and fix double-slash bug in createBackup()Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com> Agent-Logs-Url: https://github.com/nextcloud/updater/sessions/cf8949f9-d766-48cd-b56c-ec8643d0cbc4
Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com> Agent-Logs-Url: https://github.com/nextcloud/updater/sessions/cf8949f9-d766-48cd-b56c-ec8643d0cbc4
Copilot
AI
changed the title
fix: centralise path building, fix explode-based double-slash bug (issue #711), add PHPUnit
Add PHPUnit workflow, fix path handling bug, REUSE/php-cs compliance
Mar 25, 2026
|
As a total aside - how wise is it to roll so many issues into 1 PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a missing PHPUnit GitHub Actions workflow, fixes a fragile path extraction pattern inherited from issue #711, and resolves REUSE/php-cs CI failures.
PHPUnit workflow
.github/workflows/phpunit.ymlrunningcomposer run test:unitagainst PHP 8.2 / 8.3 / 8.4 on PR and pushPath handling fix (
moveWithExclusions)createBackup()had already been fixed for theexplode()-splits-on-all-occurrences bug, butmoveWithExclusions()had the identical pattern:Regression tests for issue #711
testRelativePathExtractionForIssue711()— pure logic test proving the oldexplode()returns a directory path instead of the file path for the exact bug-report scenariotestCreateBackupCopiesNestedFilesCorrectly()— integration test: createscore/doc/admin/…/nextcloud.html, runscreateBackup(), asserts the file is copied to the correct nested path with no double slashesREUSE compliance
vendor-bin/phpunit/**was not covered by any annotation inREUSE.toml. Added it to the existing block that covers the othervendor-bintool directories.php-cs
Reformatted string concatenation in
tests/unit/UpdaterTest.phpfrom trailing-dot to leading-dot style as required by the project's php-cs-fixer config.📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.